feature/add exact body check option for FullHttpRequestMatcher #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 99.28% 99.29%
=======================================
Files 24 24
Lines 280 282 +2
=======================================
+ Hits 278 280 +2
Misses 2 2
☔ View full report in Codecov by Sentry. |
|
Thank you @sebastianbuechler , this is awesome! |
LukaGiorgadze
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to require exact body matches in cases of
Maps when using theFullHttpRequestMatcherand aims to solve issue #149.When initiating the
DioAdapterit can be specified to useFullHttpRequestMatcher(needsExactBody: true)asmatcherparameter. If no value forneedsExactyBodyis provided thenfalsewill be used for default for backwards compatibility.Additional tests can be found in
test/extensions/matches_request_test.dart.